[ 
https://issues.apache.org/jira/browse/CALCITE-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367525#comment-17367525
 ] 

Rafay A edited comment on CALCITE-4644 at 6/22/21, 5:14 PM:
------------------------------------------------------------

 SqlBasicAggFunction was added recently and I did not notice that COLLECT now 
extend from it. I'll update my patch and apply your feedback.

I'll rename the word "positive". How about 
"[UNIT_INTERVAL_NUMERIC_LITERAL|https://en.wikipedia.org/wiki/Unit_interval]";

Postgres returns this error message if the argument is not in the range:
{code:java}
ERROR:  percentile value 1.5 is not between 0 and 1
ERROR:  percentile value -1.5 is not between 0 and 1
{code}
 


was (Author: rafay):
 

SqlBasicAggFunction was added recently and I did not notice that COLLECT now 
extend from it. I'll update my patch and apply your feedback.

 

I'll rename the word "positive". How about 
"[UNIT_INTERVAL_NUMERIC_LITERAL|https://en.wikipedia.org/wiki/Unit_interval]";

Postgres returns this error message if the argument is not in the range:
{code:java}
ERROR:  percentile value 1.5 is not between 0 and 1
ERROR:  percentile value -1.5 is not between 0 and 1
{code}
 

> Add PERCENTILE_CONT and PERCENTILE_DISC aggregate functions
> -----------------------------------------------------------
>
>                 Key: CALCITE-4644
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4644
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Rafay A
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add percentile functions in the operator table.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to