[ 
https://issues.apache.org/jira/browse/CALCITE-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373946#comment-17373946
 ] 

duan xiong commented on CALCITE-4665:
-------------------------------------

{code:java}
private RelBuilder example5(RelBuilder builder) {
  return builder
      .scan("EMP")
      .aggregate(builder.groupKey(ImmutableBitSet.of(0, 1 ,2),
          (Iterable<ImmutableBitSet>)
              ImmutableList.of(ImmutableBitSet.of(0,1),ImmutableBitSet.of(0))),
          builder.count(false, "C"),
          builder.sum(false, "S", builder.field("SAL"))).filter(
          builder.call(SqlStdOperatorTable.GREATER_THAN, builder.field("C"),
              builder.literal(10)))
      
.filter(builder.call(SqlStdOperatorTable.EQUALS,builder.field("JOB"),builder.literal("DEVELOP")))
      .project(builder.field("JOB"));
}
{code}
The RelNode is:
{code:java}
LogicalProject(JOB=[$2])
  LogicalFilter(condition=[=($2, 'DEVELOP')])
    LogicalFilter(condition=[>($3, 10)])
      LogicalAggregate(group=[{0, 1, 2}], groups=[[{0, 1}, {0}]], C=[COUNT()], 
S=[SUM($5)])
        LogicalTableScan(table=[[scott, EMP]]){code}
The Sql is:
{code:java}
SELECT "JOB"
FROM (SELECT "EMPNO", "ENAME", "JOB", COUNT(*) AS "C", SUM("SAL") AS "S"
FROM "scott"."EMP"
GROUP BY GROUPING SETS(("EMPNO", "ENAME"), "EMPNO")
HAVING COUNT(*) > 10) AS "t0"
WHERE "JOB" = 'DEVELOP'{code}

> When group by are same as sub-query, grouping sets are missing
> --------------------------------------------------------------
>
>                 Key: CALCITE-4665
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4665
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.22.0
>            Reporter: xiejiajun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.28.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
>  UT:
> {code:java}
>         builder.scan("EMP")
>             .aggregate(builder.groupKey(0, 1, 7),
>                 builder.aggregateCall(SqlStdOperatorTable.COUNT,
>                     builder.field("JOB")).as("job_num"))
>             .aggregate(
>                 builder.groupKey(ImmutableBitSet.of(0, 1, 2),
>                     (Iterable<ImmutableBitSet>)
>                         ImmutableList.of(ImmutableBitSet.of(0, 1))))
>             // GROUP BY 0,1,2 GROUPING SETS((0, 1))
>             .build();
> {code}
> Before I fixed it, you can see groupings set are missing because 
> LogicalProject.
> {code:java}
> LogicalProject(EMPNO=[$0], ENAME=[$1], DEPTNO=[$2])
>   LogicalAggregate(group=[{0, 1, 7}], job_num=[COUNT($2)])
>     LogicalTableScan(table=[[scott, EMP]]){code}
> After I fixed it,  groupings set will be saved.
> {code:java}
> LogicalAggregate(group=[{0, 1, 2}], groups=[[{0, 1}]])
>  LogicalAggregate(group=[{0, 1, 7}], job_num=[COUNT($2)])
>    LogicalTableScan(table=[[scott, EMP]]{code}
>   Although the user will not write such SQL directly, it does happen after 
> the logic is complicated, and the user will be confused about the wrong data.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to