[ 
https://issues.apache.org/jira/browse/CALCITE-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390682#comment-17390682
 ] 

Julian Hyde commented on CALCITE-4694:
--------------------------------------

I could make the internal constructor protected but annotate it as 
experimental. Experimental means it may change without notice in future, which 
of course could break Hive. It's a trade-off, but in my opinion Hive's decision 
to sub-class a class with a non-trivial constructor creates rather much 
coupling, so Hive should pay some of the price.

> When creating a RelOptMaterialization, if row types are not identical, create 
> a cast using a custom RelBuilder
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4694
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4694
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.25.0
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.28.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> RelOptMaterialization may add a Project on top of tableRel. This is always a 
> LogicalProject since the RelFactories.ProjectFactory is hardcoded to 
> RelFactories.DEFAULT_PROJECT_FACTORY.
> Some projects like Hive specifies its custom operators and custom 
> RelFactories instead of using the built in Logical ones.
> Example:
> {code:java}
> public class HiveProject extends Project
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to