[
https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397600#comment-17397600
]
Josh Elser commented on CALCITE-4727:
-------------------------------------
{quote}the RpMetadata JSON reference is missing the required `response` field
{quote}
To echo Julian, I'm a little confused about what needs "fixing":
Proto:
{code}
// Generic metadata for the server to return with each response.
message RpcMetadata {
string server_address = 1; // The host:port of the server
}
{code}
JSON:
{code}
public RpcMetadataResponse(@JsonProperty("serverAddress") String
serverAddress) {
this.serverAddress = serverAddress;
this.serverAddressAsBytes =
UnsafeByteOperations.unsafeWrap(serverAddress.getBytes(UTF_8));
}
{code}
Both the protobuf and JSON protocols define RpcMetadata to contain just this
one attribute "serverAddress". As far as my poor memory goes, this field does
_not_ have a response attribute (in that it's not a typical response, like that
doc you link in the description).
> Fix RpcMetadata JSON reference
> -------------------------------
>
> Key: CALCITE-4727
> URL: https://issues.apache.org/jira/browse/CALCITE-4727
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: John Bodley
> Priority: Trivial
>
> Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the
> RpMetadata JSON reference is missing the required `response` field. As
> discussed in the issue and per
> [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678],
> though this isn't an actual response is does seem to expect a response type
> signature.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
