[
https://issues.apache.org/jira/browse/CALCITE-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397883#comment-17397883
]
Enze Liu edited comment on CALCITE-4724 at 8/12/21, 7:02 AM:
-------------------------------------------------------------
Thanks for the clarification. And the change looks good to me, feel free to
squash and merge to master
was (Author: enze):
Thanks for the clarification. And the change looks good to me.
> ClickHouseSqlDialect `supportsAliasedValues` should return false.
> -----------------------------------------------------------------
>
> Key: CALCITE-4724
> URL: https://issues.apache.org/jira/browse/CALCITE-4724
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.27.0
> Reporter: Enze Liu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> We use ClickHouseSqlDialect to do some sql optimize.
> for sql `select 1`, in the process of sqlNode -> relNode -> sqlNode, the sql
> string will be transformed to
> {code:java}
> SELECT *
> FROM (VALUES (1)) AS `t` (`EXPR$0`)
> {code}
> Since clickhouse is not support AliasedValues, all we need to do is to extend
> ClickHouseSqlDialect and make `supportsAliasedValues` return false.
> Maybe this kind of behavior can integrated into core?
> If needed, the pull request is ready.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
