[
https://issues.apache.org/jira/browse/CALCITE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399120#comment-17399120
]
Julian Hyde edited comment on CALCITE-4737 at 8/14/21, 7:04 AM:
----------------------------------------------------------------
If the visualizer is not primarily about TVR, let's get it in as a separate
change, before the rest of Tempura. There could be a delta commit later, which
I imagine would be small.
On a quick review, I noticed that {{<p>}} markers should be added to javadoc;
{{```}} should be removed from javadoc; ')' should not be on a new line; and
there could be quite a few more {{final}} keywords, especially for fields.
was (Author: julianhyde):
If the visualizer is not primarily about TVR, let's get it in as a separate
change, before the rest of Tempura. There could be a delta commit later, which
I imagine would be small.
On a quick review, I noticed that {{<p>}} markers should be added to javadod;
{{```}} should be removed from javadoc; ')' should not be on a new line; and
there could be quite a few more {{final}} keywords, especially for fields.
> Add Volcano visualizer for debugging
> ------------------------------------
>
> Key: CALCITE-4737
> URL: https://issues.apache.org/jira/browse/CALCITE-4737
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Priority: Major
>
> Add Volcano visualizer for debugging.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
