[ 
https://issues.apache.org/jira/browse/CALCITE-4744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400472#comment-17400472
 ] 

Julian Hyde commented on CALCITE-4744:
--------------------------------------

Can you fix the Jira subject?

Not your fault, but the ConvertletTable seems to be too “small” an API to make 
pluggable. Most people never need to use it, and so making it pluggable 
increases their cognitive burden. 


I wonder whether expansion of aggregate functions should be deferred until 
planning time. Then you can turn off expansion of Stdev by disabling a planner 
rule. 

> Add 
> ----
>
>                 Key: CALCITE-4744
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4744
>             Project: Calcite
>          Issue Type: New Feature
>          Components: core
>            Reporter: keaton drebes
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I have a project that is working with windowed functions and we want to avoid 
> the decomposition of certain aggregate functions (i.e. stddev) in the process 
> of converting from an SqlNode to a RelNode. We have currently supported this 
> by copying the entire  StandardConvertlet table, and removing the convertlets 
> responsible for this.
> It seems reasonable to control this behavior with a configuration for the 
> StandardConvertlet table. Is this something that people would accept being 
> merged into Calcite?
> I opened a draft PR to show the changes here: 
> https://github.com/apache/calcite/pull/2496



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to