[
https://issues.apache.org/jira/browse/CALCITE-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401827#comment-17401827
]
Yingyu edited comment on CALCITE-2736 at 8/19/21, 7:26 PM:
-----------------------------------------------------------
Since the previous PR (#980) didn't get a chance to merge into master I created
this new PR by refactoring the changes using current config API.
https://github.com/apache/calcite/pull/2502
1. Add new config option treatDynamicCallsAsNonConstant.
2. Update ReducibleExprLocator.analyzeCall() method to also rely on
treatDynamicCallsAsNonConstant option when determining whether to reduce a
dynamic function.
[~julianhyde], [~vlsi], [~kgyrtkirk] could you help to review this PR since you
reviewed the old PR in the past?
was (Author: yingyu):
Since the previous PRs (#973 and #980) didn't get a chance to merge into master
I created this new PR by refactoring the changes using current config API.
https://github.com/apache/calcite/pull/2502
1. Add new config option treatDynamicCallsAsNonConstant.
2. Update ReducibleExprLocator.analyzeCall() method to also rely on
treatDynamicCallsAsNonConstant option when determining whether to reduce a
dynamic function.
[~julianhyde], [~vlsi], [~kgyrtkirk] could you help to review this PR since you
reviewed the old PRs in the past?
> ReduceExpressionsRule never reduces dynamic expressions but this should be
> configurable
> ---------------------------------------------------------------------------------------
>
> Key: CALCITE-2736
> URL: https://issues.apache.org/jira/browse/CALCITE-2736
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: Jacques Nadeau
> Assignee: Jacques Nadeau
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> There are situations where it is helpful to reduce dynamic SqlCalls. Right
> now, the ReduceExpressionsRule always avoids doing this. We should enhance
> the rule so this can be configurable depending on where in planning the rule
> is used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
