[ 
https://issues.apache.org/jira/browse/CALCITE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403026#comment-17403026
 ] 

Toni Mueller commented on CALCITE-4746:
---------------------------------------

Thank you very much for your answer.

I narrowed down the problem.
 # You are right, it does not appear to be a problem with the default config 
used.
 # It is, however a problem with the BabelParserFactory in 
`org.apache.calcite.sql.parser.babel.SqlBabelParserImpl`:
Running the following function gives the error:

{code:java}
    void testBabelPivot() throws SqlParseException {
        final String sql = "SELECT * FROM emp PIVOT (sum(sal) FOR job in 
('CLERK'))";
        SqlParser.Config c = 
SqlParser.config().withConformance(SqlConformanceEnum.BABEL)
            .withParserFactory(SqlBabelParserImpl.FACTORY);
        SqlParser parser = SqlParser.create(sql, c);
        parser.parseQuery();
    }
{code}

Changing the Factory to `SqlParserImpl.FACTORY` does not yield an error.

BTW: Am I actually using the conformance `BABEL` if I use the default 
SqlParserImpl.FACTORY?

> Pivots with pivotAgg without alias fail
> ---------------------------------------
>
>                 Key: CALCITE-4746
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4746
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.27.0
>            Reporter: Toni Mueller
>            Priority: Major
>
> The following works:
> {code:sql}
> SELECT * FROM STUDENTS PIVOT(SUM(AGE) AS sum_age FOR PROFESSION IN 
> ('BIOLOGY', 'CHEMISTRY'))
> {code}
> The following doesn't work:
> {code:sql}
> SELECT * FROM STUDENTS PIVOT(SUM(AGE) FOR PROFESSION IN ('BIOLOGY', 
> 'CHEMISTRY'))
> {code}
> With error:
> {code}
> Caused by: java.lang.RuntimeException: 
> org.apache.calcite.sql.parser.SqlParseException: Encountered "PROFESSION" at 
> line 1, column 43.
> Was expecting one of:
>     "FOR" ...
>     "," ...
>     
>       at 
> org.apache.calcite.sql.parser.SqlParseException.writeReplace(SqlParseException.java:171)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>       at 
> java.base/java.io.ObjectStreamClass.invokeWriteReplace(ObjectStreamClass.java:1235)
>       at 
> java.base/java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1137)
>       at 
> java.base/java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:349)
>       at 
> org.gradle.internal.serialize.ExceptionPlaceholder.<init>(ExceptionPlaceholder.java:133)
>       at 
> org.gradle.internal.serialize.ExceptionPlaceholder.convertToExceptionPlaceholderList(ExceptionPlaceholder.java:158)
>       at 
> org.gradle.internal.serialize.ExceptionPlaceholder.<init>(ExceptionPlaceholder.java:141)
>       at 
> org.gradle.internal.serialize.TopLevelExceptionPlaceholder.<init>(TopLevelExceptionPlaceholder.java:28)
>       at 
> org.gradle.internal.serialize.ExceptionReplacingObjectOutputStream.doReplaceObject(ExceptionReplacingObjectOutputStream.java:67)
>       at 
> org.gradle.internal.serialize.ExceptionReplacingObjectOutputStream$1.transform(ExceptionReplacingObjectOutputStream.java:31)
>       at 
> org.gradle.internal.serialize.ExceptionReplacingObjectOutputStream.replaceObject(ExceptionReplacingObjectOutputStream.java:62)
>       at 
> java.base/java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1145)
>       at 
> java.base/java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:349)
>       at org.gradle.internal.serialize.Message.send(Message.java:36)
>       at 
> org.gradle.internal.serialize.BaseSerializerFactory$ThrowableSerializer.write(BaseSerializerFactory.java:321)
>       at 
> org.gradle.internal.serialize.BaseSerializerFactory$ThrowableSerializer.write(BaseSerializerFactory.java:313)
>       at 
> org.gradle.internal.remote.internal.hub.DefaultMethodArgsSerializer$ArraySerializer.write(DefaultMethodArgsSerializer.java:80)
>       at 
> org.gradle.internal.remote.internal.hub.DefaultMethodArgsSerializer$ArraySerializer.write(DefaultMethodArgsSerializer.java:61)
>       at 
> org.gradle.internal.remote.internal.hub.MethodInvocationSerializer$MethodInvocationWriter.writeArgs(MethodInvocationSerializer.java:78)
>       at 
> org.gradle.internal.remote.internal.hub.MethodInvocationSerializer$MethodInvocationWriter.write(MethodInvocationSerializer.java:74)
>       at 
> org.gradle.internal.remote.internal.hub.MethodInvocationSerializer$MethodInvocationWriter.write(MethodInvocationSerializer.java:58)
>       at 
> org.gradle.internal.serialize.kryo.TypeSafeSerializer$2.write(TypeSafeSerializer.java:47)
>       at 
> org.gradle.internal.remote.internal.hub.InterHubMessageSerializer$MessageWriter.write(InterHubMessageSerializer.java:104)
>       at 
> org.gradle.internal.remote.internal.hub.InterHubMessageSerializer$MessageWriter.write(InterHubMessageSerializer.java:88)
>       at 
> org.gradle.internal.remote.internal.inet.SocketConnection.dispatch(SocketConnection.java:122)
>       at 
> org.gradle.internal.remote.internal.hub.MessageHub$ConnectionDispatch.run(MessageHub.java:328)
> {code}
> According to the Language Definition both should work:
> https://calcite.apache.org/docs/reference.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to