[ 
https://issues.apache.org/jira/browse/CALCITE-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403056#comment-17403056
 ] 

Stamatis Zampetakis commented on CALCITE-4747:
----------------------------------------------

[~Lam167] The summary and description are still unclear, as [~nobigo] suggested 
please try to rework them.

What is the problem that you encountered? Is it a memory leak? Is it bad 
performance? Is it an exception? Your question implies that a certain method 
({{collecGarbage}}) does not work as expected but it is not clear why its 
current behavior is problematic. 

> it seemes that collecGarbage in HepPlanner dose not clean outdated edges?
> -------------------------------------------------------------------------
>
>                 Key: CALCITE-4747
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4747
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Jianhui Dong
>            Priority: Minor
>         Attachments: image-2021-08-19-12-12-41-534.png
>
>
> !image-2021-08-19-12-12-41-534.png!
> After we use HepPlanner to optimize the RelNode,  we need to replace old 
> RelNode with the optimized RelNode, and update the graph in HepPlanner, but 
> calcite only remove the outdated RelNode(HepRelVertex) in line 970. I think 
> maybe we should also remove the outdated edge.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to