[
https://issues.apache.org/jira/browse/CALCITE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412891#comment-17412891
]
zhishui commented on CALCITE-4764:
----------------------------------
I look and test CALCITE-4736, I think there are different situations.
When we use below example.Attention, literal 10 in sql mv2 is integer while
corresponding value in CALCITE-4736 is string would cause problem above on.
Except this, there have a lot symptoms.
@Test void testQueryRewriteFlowFail() { final String mv1 = ""
+ "select count(1) as cnt " + "from \"emps\" " + "where
cast(\"commission\" as varchar) = '20' " + "group by \"deptno\"";
final String mv2 = ""
+ "select count(1) as cnt " + "from \"emps\" " + "where
cast(\"commission\" as varchar) = 10 " + "group by \"deptno\""; final
String query = ""
+ "select count(1) as cnt " + "from \"emps\" " + "where
cast(\"commission\" as varchar) = '10' " + "group by \"deptno\"";
sql(ImmutableList.of(mv1, mv2), query).ok();
}
> RexImplicationChecker throw ex, when meeting RexNode with `CAST` operator.
> --------------------------------------------------------------------------
>
> Key: CALCITE-4764
> URL: https://issues.apache.org/jira/browse/CALCITE-4764
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Xurenhe
> Priority: Major
> Attachments: image-2021-09-05-17-02-58-266.png,
> image-2021-09-06-08-17-20-788.png
>
>
> I run an example in `RexImplicationChecker`, but it throw ex.
> {code:sql}
> col is a field of Java type "Integer"
> rexnode1: cast(col as char) > '10'
> rexnode2: cast(col as char) > '20'
> {code}
> I debug it, found some unclear code in
> `org.apache.calcite.plan.RexImplicationChecker.InputUsageFinder#updateBinaryOpUsage`.
> I found `InputUsageFinder` will discard `CAST`, as screenshot
> !image-2021-09-05-17-02-58-266.png!
> ----
> Should we enchane code here?
> And, it may be root reason of
> [CALCITE-4736|https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-4736]
> ----
> Complete test:
> {code:java}
> @Test void testSimple() {
> final Fixture f = new Fixture();
> final RexNode xGeB = f.ge(f.cast(f.charDataType, f.i),
> f.charLiteral("20"));
> final RexNode xGeA = f.ge(f.cast(f.charDataType, f.i),
> f.charLiteral("10"));
> f.checkImplies(xGeB, xGeA);
> }
> {code}
> ----
> I will follow and improve it, If it's a deficiency.
> Thanks a lot.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
