[
https://issues.apache.org/jira/browse/CALCITE-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17413019#comment-17413019
]
Stamatis Zampetakis commented on CALCITE-4747:
----------------------------------------------
Hey [~fan_li_ya], thanks for reviewing and merging this to master, and of
course thanks to [~Lam167] for reporting and working on this issue.
Few minor comments for future contributions/merges:
Ensure the commit message follows the Calcite
[guidelines|https://calcite.apache.org/develop/#contributing] and follows the
style of the other commits. In this case:
* it should start with a capital letter;
* the double colon ':' after the JIRA id shouldn't be there;
* it should have the contributors (if not committer) name inside parentheses at
the end.
The JIRA summary should clearly and concisely describe the problem, feature,
change.
When the JIRA is resolved it should always have a fix version assigned.
Sorry for bringing up these small details but it helps saving time for various
people in the future (especially release managers).
> Remove outdated graph edges in HepPlanner
> -----------------------------------------
>
> Key: CALCITE-4747
> URL: https://issues.apache.org/jira/browse/CALCITE-4747
> Project: Calcite
> Issue Type: Improvement
> Reporter: Jianhui Dong
> Priority: Minor
> Labels: pull-request-available
> Attachments: image-2021-08-19-12-12-41-534.png
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> !image-2021-08-19-12-12-41-534.png!
> After we use HepPlanner to optimize the RelNode, we need to replace old
> RelNode with the optimized RelNode, and update the graph in HepPlanner, but
> calcite only remove the outdated RelNode(HepRelVertex) in line 970, the edges
> between these vertices are still in the graph, which may cause a memory leak?
> IMO, I think maybe we should also remove the outdated edge.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
