[
https://issues.apache.org/jira/browse/CALCITE-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414322#comment-17414322
]
Jianhui Dong commented on CALCITE-4766:
---------------------------------------
Sorry, I did not receive the email reminder in my mailbox, so I could not see
your reply in time. And Thanks for your suggestion![~zabetak] [~wojustme]
> Remove unreachable code from SqlValidatorImpl#performUnconditionalRewrites
> for VALUES node
> ------------------------------------------------------------------------------------------
>
> Key: CALCITE-4766
> URL: https://issues.apache.org/jira/browse/CALCITE-4766
> Project: Calcite
> Issue Type: Improvement
> Reporter: Jianhui Dong
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.28.0
>
> Attachments: image-2021-09-08-15-46-09-395.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> in SqlValidatorImpl line 1387, there is a line `if (underFrom || true)`:
> !image-2021-09-08-15-46-09-395.png!
> The condition is always true and I think we can remove this condition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
