[
https://issues.apache.org/jira/browse/CALCITE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417862#comment-17417862
]
Julian Hyde commented on CALCITE-3583:
--------------------------------------
Can you change the subject to "Externalize Exchange operator to and from JSON"?
"Serialize" misleadingly implies that we are using Java serialization
({{interface Serializable}}).
> Support serialized to json and deserialized from json for Exchange relation
> operator
> ------------------------------------------------------------------------------------
>
> Key: CALCITE-3583
> URL: https://issues.apache.org/jira/browse/CALCITE-3583
> Project: Calcite
> Issue Type: Improvement
> Reporter: Wang Yanlin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Currently, serialize Exchange relnode to json will cause exception
> {code:java}
> // RelWriterTest
> @Test public void testExchange() {
> final FrameworkConfig config = RelBuilderTest.config().build();
> final RelBuilder builder = RelBuilder.create(config);
> final RelNode rel = builder
> .scan("EMP")
> .exchange(RelDistributions.hash(ImmutableList.of(0, 1)))
> .build();
> String relJson = RelOptUtil.dumpPlan("", rel,
> SqlExplainFormat.JSON, SqlExplainLevel.EXPPLAN_ATTRIBUTES);
> String s = deserializeAndDumpToTextFormat(getSchema(rel), relJson);
> final String expected = ""
> + "LogicalExchange(distribution=[hash[0, 1]])\n"
> + " LogicalTableScan(table=[[scott, EMP]])\n";
> assertThat(s, isLinux(expected));
> }
> {code}
> got
> {code:java}
> java.lang.UnsupportedOperationException: type not serializable: hash[0, 1]
> (type org.apache.calcite.rel.RelDistributions.RelDistributionImpl)
> at org.apache.calcite.rel.externalize.RelJson.toJson(RelJson.java:290)
> at
> org.apache.calcite.rel.externalize.RelJsonWriter.put(RelJsonWriter.java:83)
> at
> org.apache.calcite.rel.externalize.RelJsonWriter.explain_(RelJsonWriter.java:66)
> at
> org.apache.calcite.rel.externalize.RelJsonWriter.done(RelJsonWriter.java:128)
> at
> org.apache.calcite.rel.AbstractRelNode.explain(AbstractRelNode.java:299)
> at org.apache.calcite.plan.RelOptUtil.dumpPlan(RelOptUtil.java:1981)
> at
> org.apache.calcite.plan.RelWriterTest.testExchange(RelWriterTest.java:772)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
