[
https://issues.apache.org/jira/browse/CALCITE-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424059#comment-17424059
]
Jacques Nadeau commented on CALCITE-4787:
-----------------------------------------
> When you mark a bug fixed please set the fix-version. Also use a hyperlink to
>the github commit.
Fixed, thanks for the reminders!
> Are you going to do the follow-up tasks, such as CALCITE-4825,
Yep. Working on that one right now.
> and if so, will this be done before release 1.28? A half-done breaking change
> may be difficult to explain in the release notes.
My goal is to get as many as possible done before the release (ideally all).
That being said, given the way that the patch ultimately turned out, I don't
think there is a global breaking change change here that requires that this be
all or nothing in a particular release. Mainly, my thinking is we shouldn't
mark ImmutableBeans deprecated until no more Calcite code is using it. I'd like
to get there before 1.28 but will have to see if I hit any snags as I work
through the rest of the codebase.
> Move core to use Immutables instead of ImmutableBeans
> -----------------------------------------------------
>
> Key: CALCITE-4787
> URL: https://issues.apache.org/jira/browse/CALCITE-4787
> Project: Calcite
> Issue Type: Improvement
> Reporter: Jacques Nadeau
> Assignee: Jacques Nadeau
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.28.0
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> In the creation of CALCITE-3328, [Immutables|https://immutables.github.io/]
> was discussed as an alternative to a custom implementation. This ticket is to
> evaluate the impact to the codebase of changing. Ideally, introduction of
> immutables would both add flexibility and reduce the amount of code
> associated with these classes.
> Immutables works via annotation processor which means that it is should be
> relatively seamless to build systems and IDEs.
> The switch would also make it easier to work with these objects types in the
> context of aot compilation tools like GraalVM.
>
> This initial task covers key classes in the core module. Will open up
> follow-on tickets for other locations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
