[ 
https://issues.apache.org/jira/browse/CALCITE-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17425460#comment-17425460
 ] 

Xurenhe commented on CALCITE-4818:
----------------------------------

[~tledkov-gridgain] Sorry, it's my mistake. I try to code this test case, but I 
forget to define  a type system to write return's type of SUM. so, I meet some 
error stack as above.
I thought it would affect the upper operator of project, if it exists. So, I 
want more testes to cover, but there is no difference between the two test 
cases.

----
I'm sorry to my carelessness.

 

> AggregateExpandDistinctAggregatesRule must infer correct data type for top 
> aggregate calls
> ------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4818
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4818
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.27.0
>            Reporter: Taras Ledkov
>            Assignee: Taras Ledkov
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.28.0
>
>
> When SUM data type derivation is more complex, e.g.:
> {code}
> SUM(TINYINT | SMALLINT | INTEGER) -> BIGINT
> SUM(BIGINT) -> DECIMAL
> {code}
> The rule {{AggregateExpandDistinctAggregatesRule}} creates the top aggregate 
> calls with invalid type for not distinct calls.
> e.g. {{SELECT SUM(comm), SUM(DISTINCT comm) FROM emp}}
> Please take a look at the reproducer in the PR.
> *Proposed fix:*  infer type of top aggregates by input row type. Pass 
> {{null}} type to the call method {{AggregateCall#create}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to