[ 
https://issues.apache.org/jira/browse/CALCITE-4817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426404#comment-17426404
 ] 

Haisheng Yuan commented on CALCITE-4817:
----------------------------------------

Reverted the previous commit.

> Expand SubstitutionVisitor of Aggregate with max/min, which column is the 
> group by list of target
> -------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4817
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4817
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Xurenhe
>            Assignee: Xurenhe
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2021-10-08-18-48-56-093.png, 
> image-2021-10-08-20-14-10-791.png
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Now, SubstitutionVisitor support `Query with distinct aggregate on the column 
> is matched to the group list existing in target`, as CALCITE-4374 describes.
> But. It's fail, when query aggregate with max/min based on the column, which 
> is in the group by list of target.
> Materialized view recognition should also success.
> {code:java}
> //代码占位符
> @Test void testQueryNoDistinctOptionalityAggCallColInTargetGroupBy1() {
>   final String mv = ""
>       + "select \"name\", \"deptno\" "
>       + "from \"emps\" group by \"name\", \"deptno\"";
>   final String query = ""
>       + "select \"name\", min(\"deptno\")\n"
>       + "from \"emps\" group by \"name\"";
>   sql(mv, query).ok();
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to