[
https://issues.apache.org/jira/browse/CALCITE-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jesus Camacho Rodriguez resolved CALCITE-4550.
----------------------------------------------
Fix Version/s: 1.28.0
Resolution: Fixed
Fixed in
[77ff9f6|https://github.com/apache/calcite/commit/77ff9f6145272a899f694c6a2d8ab8ff5422d0c6].
Thanks [~jamesstarr]!
> Simplify JaninoRelMetadataProvider API for binding methods
> ----------------------------------------------------------
>
> Key: CALCITE-4550
> URL: https://issues.apache.org/jira/browse/CALCITE-4550
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Reporter: James Starr
> Assignee: James Starr
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.28.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> JaninoRelMetadataProvider uses the a complicated convention for binding
> handler instances to a the dynamically created handler. It requires the
> method to stated once in Metadata, then again MetadataHandler with slightly
> different signature and finally again a reference to the Metadata method must
> be included MetadataDef. This is needlessly rather complicated and verbose
> for something that is trying to reduce boiler plate.
> Having JaninoRelMetadataProvider get the declared methods directly from the
> handler interface would decouple JaninoRelMetadataProvider from method
> definitions in Metadata and MetadataDef.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
