[ 
https://issues.apache.org/jira/browse/CALCITE-4732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429460#comment-17429460
 ] 

Julian Hyde edited comment on CALCITE-4732 at 10/15/21, 6:56 PM:
-----------------------------------------------------------------

Thank you, this is a huge improvement. Especially calling out the Elasticsearch 
adapter in the title.

Some other improvements:
* Always use upper-case for SQL keywords such as GROUP BY.
* Are the data types mentioned Java data types or SQL data types? If they are 
SQL data types, use upper case, e.g. DATE and VARCHAR.


was (Author: julianhyde):
Always use upper-case for SQL keywords such as GROUP BY.

Are the data types mentioned Java data types or SQL data types? If they are SQL 
data types, use upper case, e.g. DATE and VARCHAR.

> In Elasticsearch adapter, group by date type field will return Long value 
> replace date String
> ---------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4732
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4732
>             Project: Calcite
>          Issue Type: Bug
>          Components: elasticsearch-adapter
>            Reporter: james yang
>            Priority: Major
>
> when I execute a sql group by a date type field ,I get the int value of the 
> date not the string value



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to