[ 
https://issues.apache.org/jira/browse/CALCITE-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443007#comment-17443007
 ] 

Julian Hyde commented on CALCITE-4877:
--------------------------------------

I apologize. I didn't notice that you'd added the text. I think you should 
leave the PNG, since it's already there.

In future, please provide the text rather than the PNG. The text is searchable, 
more accessible (e.g. to people with visual impairments), we can include it in 
comments, etc.

> Make the exception information of class not found more explicit
> ---------------------------------------------------------------
>
>                 Key: CALCITE-4877
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4877
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: image-2021-11-06-07-03-57-742.png
>
>          Time Spent: 10h
>  Remaining Estimate: 0h
>
> Make the exception information of class not found more explicit when we want 
> REATE SCHEMA or CREATE TABLE supported.
>  when we not add the class to the class path we got the exception as follows:
> {code}
> Error: Error while executing SQL "CREATE TABLE t (i INTEGER, j VARCHAR(10))": 
> Property 'org.apache.calcite.sql.parser.ddl.SqlDdlParserImpl#FACTORY' not 
> valid for plugin type org.apache.calcite.sql.parser.SqlParserImplFactory 
> (state=,code=0)
> {code}
>  !image-2021-11-06-07-03-57-742.png! 
> {code}
>  would be great if we can make the error message more explicit , such as: 
> "Property 'org.apache.calcite.sql.parser.ddl.SqlDdlParserImpl#FACTORY' not 
> valid as 'org.apache.calcite.sql.parser.ddl.SqlDdlParserImpl' not found in 
> the classpath."  
> {code}
> What do you think?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to