[
https://issues.apache.org/jira/browse/CALCITE-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448932#comment-17448932
]
Jing Zhang commented on CALCITE-4888:
-------------------------------------
[~nobigo]Hello, maybe you misunderstand my meaning. You concern is a problem,
of course, but it's a problem which we aim to solve in this ticket. The problem
you referred belongs to implicit type conversion, it also exists in other cases.
{code:java}
select * from table1 where name = 'xb fadfad'
select * from table1 where name = 'xb'
select * from table1 where name < 'xb'
{code}
Besides, the pr would not change the behavior of Postgres, because
`PostgresqlSqlDialect` does not enable
`shouldConvertRaggedUnionTypesToVarying`. You could also check the
`RexBuilderTest#testMakeInCharWithDiffLength`, I've added the UT in the UT.
BTW, I've updated the JIRA description to describe what problem I want to
solve. Maybe it could help you to understand.
> Unify type inferring logical for Sarg RexLiteral
> ------------------------------------------------
>
> Key: CALCITE-4888
> URL: https://issues.apache.org/jira/browse/CALCITE-4888
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Jing Zhang
> Priority: Major
> Labels: pull-request-available
> Attachments: image-2021-11-23-10-31-05-137.png
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There exists some inconsistency to infer type of Sarg RexLiteral.
> 1. The method `RexSargBuilder#getType` in `RexSimplify` using
> `rexBuilder.typeFactory.leastRestrictive(Util.distinctList(types));`
> 2. The methods `RexBuilder#makeIn` and `RexBuilder#makeBetween` using type of
> first ranges as Sarg RexLiteral's type.
> It's better to unify type inferring logical for Sarg RexLiteral.
> IMO, I think using
> `rexBuilder.typeFactory.leastRestrictive(Util.distinctList(types));` is more
> reasonable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
