[
https://issues.apache.org/jira/browse/CALCITE-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Solimando updated CALCITE-4917:
------------------------------------------
Description:
Simplification (from _RexSimplify_ class) is mostly covered in
{_}RexProgramTest{_}, but tests for expressions of the form "IS NOT NULL(a) AND
a=b" (with nullable and not nullable types) seem to be missing.
Since I had to write tests to make sure the simplification was as expected, I
assume others might end up doing the same, and that the tests will both act as
documentation and it will also protect against regressions.
was:
Simplification (from _RexSimplify_ class) is mostly covered in
{_}RexProgramTest{_}, a test for
expressions of the form "IS NOT NULL(a) AND a=b" => "a=b" under the
"UnknownAsFalse" semantics and not simplified under "UnknownAsUnknown" one,
seems uncovered.
Since I had to write a test to make sure the simplification was as expected, I
assume others might end up doing the same, and that the test will both act as
documentation and it will also protect against regressions.
> Add test for 'IS NOT NULL(a) AND a=b' simplification
> ----------------------------------------------------
>
> Key: CALCITE-4917
> URL: https://issues.apache.org/jira/browse/CALCITE-4917
> Project: Calcite
> Issue Type: Test
> Components: core
> Affects Versions: 1.28.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Simplification (from _RexSimplify_ class) is mostly covered in
> {_}RexProgramTest{_}, but tests for expressions of the form "IS NOT NULL(a)
> AND a=b" (with nullable and not nullable types) seem to be missing.
>
> Since I had to write tests to make sure the simplification was as expected, I
> assume others might end up doing the same, and that the tests will both act
> as documentation and it will also protect against regressions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
