[
https://issues.apache.org/jira/browse/CALCITE-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452657#comment-17452657
]
Julian Hyde commented on CALCITE-4917:
--------------------------------------
As a general rule we add a test method (or methods) when we fix a Jira case
that is a bug or a feature, and label that method. This allows people to find
the Jira case from the method, and read the design discussion around that bug.
But this case is not a bug (or a feature) so I think those rules don't apply.
It's a judgment call. The goal is a maintainable code base that builds
community. I will support whatever you think best.
> Add test for 'a IS NOT NULL AND a = b' simplification
> -----------------------------------------------------
>
> Key: CALCITE-4917
> URL: https://issues.apache.org/jira/browse/CALCITE-4917
> Project: Calcite
> Issue Type: Test
> Components: core
> Affects Versions: 1.28.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Simplification (from _RexSimplify_ class) is mostly covered in
> {_}RexProgramTest{_}, but tests for expressions of the form "IS NOT NULL(a)
> AND a=b" (with nullable and not nullable types) seem to be missing.
>
> Since I had to write tests to make sure the simplification was as expected, I
> assume others might end up doing the same, and that the tests will both act
> as documentation and it will also protect against regressions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
