[
https://issues.apache.org/jira/browse/CALCITE-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453675#comment-17453675
]
Francesco Gini commented on CALCITE-4907:
-----------------------------------------
I meant done on the Jira changes "JDBC adapter cannot push down join ON TRUE
(cartesian product) or ON FALSE" . For the pr changes I was waiting to know if
I needed to check the type of literal. I have now updated the PR as well as
suggested.
I am still not clear why a literal in a RexNode is always a boolean. I mean it
makes sense, but I'd be curious to know where that is enforced. I was kind of
expecting a check in the {{Join}} class but I couldn't find it there.
> JDBC adapter cannot push down join ON TRUE (cartesian product) or ON FALSE
> ---------------------------------------------------------------------------
>
> Key: CALCITE-4907
> URL: https://issues.apache.org/jira/browse/CALCITE-4907
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
> Affects Versions: 1.28.0
> Reporter: Francesco Gini
> Assignee: Francesco Gini
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.29.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> JDBC adapter (in JdbcJoinRule) cannot push down join ON TRUE (cartesian
> product) or ON FALSE. This results in implementing the join in memory via
> _EnumerableNestedLoopJoin_ which is a less efficient implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
