[
https://issues.apache.org/jira/browse/CALCITE-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457067#comment-17457067
]
Francesco Gini commented on CALCITE-4905:
-----------------------------------------
[~julianhyde] [~zabetak] thanks. In that case, am I ok making the deprecation
change referencing this ticket or should I open a new one and close this one?
I suppose we want to remove the deprecated code in version 2.0 ? Together with
deprecating the code I would also remove the registration of the
{{JdbcCalcRule}}
> JdbcCalc does not extend Calc
> -----------------------------
>
> Key: CALCITE-4905
> URL: https://issues.apache.org/jira/browse/CALCITE-4905
> Project: Calcite
> Issue Type: Bug
> Components: jdbc-adapter
> Affects Versions: 1.28.0
> Reporter: Francesco Gini
> Assignee: Francesco Gini
> Priority: Major
> Labels: pull-request-available
> Attachments: test_with_failing_JdbcCalc_conversion.patch
>
>
> {{JdbcCalc}} class does not implement Calc. Failing to do that means that
> {{RelToSqlConverter}} cannot translate a plan with {{JdbcCalc}} into sql
> because {{RelToSqlConverter}} expects
> {code:java}
> public Result visit(Calc e){code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
