Francesco Gini created CALCITE-4932:
---------------------------------------
Summary: Deprecate JdbcCalc and JdbcCalcRule
Key: CALCITE-4932
URL: https://issues.apache.org/jira/browse/CALCITE-4932
Project: Calcite
Issue Type: Task
Components: jdbc-adapter
Affects Versions: 1.28.0
Reporter: Francesco Gini
The jdbc adapter includes a node and rule for {{Calc}} ( {{{}JdbcCal{}}}c a
{{JdbcCalcRule}} ). {{Calc}} is an operation that is introduced only later in
the planner to optimise certain code generation and it is not needed for the
jdbc adapter.
As it stands the rule {{JdbcCalcRule}} is never triggered because the {{Jdbc}}
convention rules are applied before the {{Calc}} node is introduced in the
plan. However, if a user try to use a custom rule set they might end up with a
{{JdbcCalc}} which introduces problems like the one described in
https://issues.apache.org/jira/browse/CALCITE-4905 .
Because {{JdbcCalc}} is not an optimisation needed for jdbc anyway we should
deprecate {{JdbcCalc}} and its respective rule {{{}JdbcCalcRule{}}}. The rule
should also be removed from {{JdbcRules.rules}}
See ticket https://issues.apache.org/jira/browse/CALCITE-4905 for a discussion
around deprecating {{JdbcCalc}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
