[ 
https://issues.apache.org/jira/browse/CALCITE-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460698#comment-17460698
 ] 

Stamatis Zampetakis commented on CALCITE-4737:
----------------------------------------------

After some thinking, I think it is better to defer the discussion about the 
system property/logger etc in a follow up JIRA since it's not the main part of 
this contribution (and people tend to have various opinions). What would be 
good to have as part of this PR is tests. The tests serve three purposes: i) 
demonstrate how the API is used; (ii) demonstrate how the output look like; 
(iii) guard against regressions.

The system property etc might make tests more difficult to write so that's why 
I think it would be better to defer this part to another JIRA.

> Add Volcano visualizer for debugging
> ------------------------------------
>
>                 Key: CALCITE-4737
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4737
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Thomas Rebele
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.29.0
>
>          Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> Add Volcano visualizer for debugging.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to