[ 
https://issues.apache.org/jira/browse/CALCITE-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461779#comment-17461779
 ] 

ZheHu commented on CALCITE-4949:
--------------------------------

Hi, [~jnadeau].
I've checked ES discuss(see 
[18131|https://github.com/elastic/elasticsearch/issues/18131]) and Maven 
Central for "lang-painless" dependency. We still need to stick to the 3rd-party 
jar for test purpose.
And I also move some old 
[comments|https://github.com/apache/calcite/blob/94e6272d57478a5913cb51e7df5c25e67511229a/elasticsearch/pom.xml#L113]
 here, which I find it necessary for other developers. 
[PR|https://github.com/apache/calcite/pull/2650] is ready for review.

> Evaluate if using "org.codelibs" is appropriate for an Elasticsearch painless 
> dependency
> ----------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4949
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4949
>             Project: Calcite
>          Issue Type: Improvement
>          Components: elasticsearch-adapter
>            Reporter: Jacques Nadeau
>            Assignee: ZheHu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There was an old comment 
> [here|https://github.com/apache/calcite/blob/94e6272d57478a5913cb51e7df5c25e67511229a/elasticsearch/pom.xml]
>  that said:
> {code}
>       Elastic search doesn't export painless script artifact to maven central.
>       Using 3rd party version (codelibs)
>       This JAR is used only in tests
> {code}
> This was referring to org.codelibs.elasticsearch.module:lang-painless 
> dependency. Is this still true or can we update this to a proper first-party 
> jar?
> Came up during review of CALCITE-4948



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to