[
https://issues.apache.org/jira/browse/CALCITE-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468834#comment-17468834
]
Julian Hyde commented on CALCITE-4975:
--------------------------------------
As I said on the dev list:
* One or two places I’d create a function rather than having a blob of code
inline. (E.g. a {{countMatches}} method.)
* In the CSV adapter, I'd use {{{}Locale.ROOT{}}}. Calcite is a server, so
never uses default locale or time zone. (You originally used
{{{}Locale.getDefault(){}}}, so the current {{Locale.ENGLISH}} is an
improvement.)
Also:
* I'd rename {{DruidFilters}} to {{DruidFilterSet}} (plural class names
complicate things), make its members package-protected, and remove the getter
methods.
* Do you believe {{date.atZone(ZoneOffset.UTC).toInstant().toEpochMilli()}} to
be efficient code? If not, would it be more efficient to work in instants all
along?
> Remove dependency to commons-lang3
> ----------------------------------
>
> Key: CALCITE-4975
> URL: https://issues.apache.org/jira/browse/CALCITE-4975
> Project: Calcite
> Issue Type: Improvement
> Reporter: Gunnar Morling
> Priority: Major
>
> It's used only in a few places, so the dependency can easily be removed,
> reducing the number of transitive dependencies introduced to an application
> via Calcite.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
