[ 
https://issues.apache.org/jira/browse/CALCITE-4992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480132#comment-17480132
 ] 

James Turton commented on CALCITE-4992:
---------------------------------------

Thanks [~VAE], I will resolve your GitHub comments.  Drill's ES plugin is not a 
lot of code and may be viewed here

[https://github.com/apache/drill/tree/master/contrib/storage-elasticsearch]

Classes like DrillElasticsearchTableScan and ElasticsearchDynamicTable will 
probably be of interest.

> RestClient resource leak in ElasticSearch adapter
> -------------------------------------------------
>
>                 Key: CALCITE-4992
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4992
>             Project: Calcite
>          Issue Type: Bug
>          Components: elasticsearch-adapter
>    Affects Versions: 1.29.0
>            Reporter: James Turton
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.30.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> RestClient instances should receive a `close()`call at the end of their 
> lifecyle, as documented here.
> [https://www.elastic.co/guide/en/elasticsearch/client/java-rest/current/java-rest-low-usage-initialization.html]
> We have monitored file descriptor leaks on systems running Apache Drill and 
> found that they are associated with Drill's ElasticSearch plugin, and that in 
> turn makes use of Calcite's ElasticSearch adapter.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to