[ 
https://issues.apache.org/jira/browse/CALCITE-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489098#comment-17489098
 ] 

Julian Hyde commented on CALCITE-4996:
--------------------------------------

[~mkou], In my 
[julianhyde/4996-rel-json|https://github.com/julianhyde/calcite/tree/4996-rel-json]
 branch I did some refactoring to pass in both {{int ordinal}} and also 
{{{}Map<String, Object> map{}}}. Every input has an integer "input" field 
(that's how {{RelJson}} recognizes it as an input) but I wanted to be able to 
pass in additional fields, hence the Map.

It is a pattern that we can follow to add handlers for other types in future.

> [RelJson] create a new public toRex method which can override makeInputRef
> --------------------------------------------------------------------------
>
>                 Key: CALCITE-4996
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4996
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Marieke Gueye
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> In the case of our project, the environment that generates a JSON from a 
> RexNode and the environment that reads it are different. We need to 
> "translate" the inputs into their aliases in the new cluster. 
> This method will permit to give more freedom to the JSON RexNode parser if 
> needed. 
> {code}
> /**
>    * Transforms a RexNode tree defined in a map (from a JSON) into a RexNode
>    * Applying a special method to inputs instead of transforming them into 
> inputRef
>    * @param cluster The optimization environment
>    * @param apply is a InputTranslator lambda that transforms the map 
> representing input
>    *               references into a RexNode
>    * @param o the map derived from a RexNode transformed into a JSON
>    * @return the transformed RexNode
>    */
> {code}
> Make sure that {{RexNode toRex(RelInput relInput, @PolyNull Object o)}} is 
> still working + adding tests 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to