[ 
https://issues.apache.org/jira/browse/CALCITE-5000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490753#comment-17490753
 ] 

Xurenhe edited comment on CALCITE-5000 at 2/14/22, 2:09 AM:
------------------------------------------------------------

As [~nobigo]  suggested, I add some common functions, which could be simplified 
by grouping.
{code:java}
-- field `x` exists in aggregate's group

max(x) => x
min(x) => x
avg(x) => x
any_value(x) => x {code}


was (Author: wojustme):
As [~nobigo]  suggested, I add some common functions, which could be simplified 
by grouping.
{code:java}
-- group by x

max(x) => x
min(x) => x
any_value(x) => x {code}

> Expand rule of `AGGREGATE_REDUCE_FUNCTIONS`, when arg of agg-call is in the 
> aggregate's group
> ---------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5000
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5000
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Xurenhe
>            Assignee: Xurenhe
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Using calcite's SubstitutionVisitor, we need do a lot work about 
> canonicalizing relnode.
> Some sql should be simplified.
> {noformat}
> -- origin sql
> select deptno, salary, max(salary), min(commission) 
> from emps 
> group by deptno, salary
> -- simplified
> select deptno, salary, salary as expr, min(commission) 
> from emps 
> group by deptno, salary{noformat}
> It should be simplified, but I didn't find any rule to simplify it.
> This issue is related to CALCITE-4857



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to