[
https://issues.apache.org/jira/browse/CALCITE-5044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511322#comment-17511322
]
Xurenhe edited comment on CALCITE-5044 at 3/23/22, 3:40 PM:
------------------------------------------------------------
[~julianhyde]
Ok, Got it.
It's really closely related to *isOrderByOrdinal()*
PR has been updated. Please review it, if you have a time.
Thanks a lot.
[https://github.com/apache/calcite/pull/2749/files]
was (Author: wojustme):
Ok, Got it.
It's really closely related to *isOrderByOrdinal()*
PR has been updated. Please review it, if you have a time.
Thanks a lot.
https://github.com/apache/calcite/pull/2749/files
> OrderBy constant executing RelToSql ambiguously
> -----------------------------------------------
>
> Key: CALCITE-5044
> URL: https://issues.apache.org/jira/browse/CALCITE-5044
> Project: Calcite
> Issue Type: Improvement
> Reporter: Xurenhe
> Assignee: Xurenhe
> Priority: Major
> Attachments: image-2022-03-17-21-45-22-988.png
>
>
>
> There is ambiguous in the rel-to-sql's converter when meeting `order by
> constant `.
> Here is an example:
> {code:java}
> @Test void testOderByConstant() {
> final Function<RelBuilder, RelNode> relFn = b -> b
> .scan("EMP")
> .project(b.literal(1), b.field(1), b.field(2))
> .sort(RelCollations.of(ImmutableList.of(
> new RelFieldCollation(0), new RelFieldCollation(1))))
> .project(b.field(2), b.field(1))
> .build();
> final String expected = "";
> relFn(relFn).ok(expected);
> } {code}
> Return sql:
> {code:java}
> SELECT "JOB", "ENAME"
> FROM "scott"."EMP"
> ORDER BY 1, "ENAME" {code}
> But, `ORDER BY 1` may mean 'sort by the first column in the select list'
> because of SqlConformance#isSortByOrdinal.
>
> I keep this the same semantics, by apply the rule of
> `CoreRules#SORT_REMOVE_CONSTANT_KEYS`
> Should the rel_to_sql's converter support it natively?
> *CODE:*
> https://github.com/wojustme/calcite/blob/6ad04e85875d9202e592a78cca8db807c5bde362/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java#L1601
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
