[ 
https://issues.apache.org/jira/browse/CALCITE-5064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512122#comment-17512122
 ] 

Julian Hyde commented on CALCITE-5064:
--------------------------------------

The other commonly used driver is 
[bqjdbc|https://github.com/looker-open-source/bqjdbc]. I [see that it 
returns|https://github.com/looker-open-source/bqjdbc/blob/1ee44c6c57746cd3c6be5e376a165f2c2165b683/src/main/java/net/starschema/clouddb/jdbc/BQDatabaseMetadata.java#L694]
 databaseProductName "Google Big Query".

I would appreciate if recognize that product name, so there's a chance that 
your fix will work for bqjdbc also.

> Dialect factory returns ANSI SQL dialect for BigQuery
> -----------------------------------------------------
>
>                 Key: CALCITE-5064
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5064
>             Project: Calcite
>          Issue Type: Bug
>          Components: jdbc-adapter
>    Affects Versions: 1.30.0
>            Reporter: Vova Vysotskyi
>            Assignee: Vova Vysotskyi
>            Priority: Major
>
> `SqlDialectFactoryImpl.create` returns `AnsiSqlDialect` for the case of 
> BigQuery instead of `BigQuerySqlDialect`.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to