[
https://issues.apache.org/jira/browse/CALCITE-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517179#comment-17517179
]
Jiajun Xie edited comment on CALCITE-5048 at 4/5/22 2:06 AM:
-------------------------------------------------------------
The case that in describe is failed because *RelDecorrelator.* I added a
*Relbuilder#sortLimit* method to support it. The new *sortLimit* support use
RexDynamicParam as parameter, and old *sortLimit* keep the original logic.
At the same time, I use *Intellij IDEA* to search the code using
{*}Rexliteral#intValue{*}. Checked the code containing fetch:
- *EnumerableMergeUnionRule* is correct, because CALCITE-3221
if (sort.offset == null) \{ inputFetch = sort.fetch; }
else if (sort.fetch instanceof RexLiteral && sort.offset instanceof RexLiteral)
\{ inputFetch = call.builder().literal( RexLiteral.intValue(sort.fetch) +
RexLiteral.intValue(sort.offset)); }
- *RelMdMaxRowCount/RelMdMinRowCount/RelMdUtil* all are error, I fixed them
like CALCITE-2061.
- Except for the core module, other modules(druid) should be related to the
engine. I won't deal with it in this
[PR|https://github.com/apache/calcite/pull/2763]. After my investigation, I
will consider whether to create a ticket to solve them
was (Author: jiajunbernoulli):
The case that in describe is failed because *RelDecorrelator.* I added a
*Relbuilder#sortLimit* method to support it. The new *sortLimit* support use
RexDynamicParam as parameter, and old *sortLimit* keep the original logic.
At the same time, I use *Intellij IDEA* to search the code using
{*}Rexliteral#intValue{*}. Checked the code containing fetch:
- *EnumerableMergeUnionRule* is correct, because CALCITE-3221
if (sort.offset == null) \{ inputFetch = sort.fetch; }
else if (sort.fetch instanceof RexLiteral && sort.offset instanceof RexLiteral)
\{ inputFetch = call.builder().literal( RexLiteral.intValue(sort.fetch) +
RexLiteral.intValue(sort.offset)); }
- *RelMdMaxRowCount/RelMdMinRowCount/RelMdUtil* all are error, I fixed them
like CALCITE-2061.
- Except for the core module, other modules(druid) should be related to the
engine. I won't deal with it in this
[PR|https://github.com/apache/calcite/pull/2763].
> Query with parameterized LIMIT and correlated sub-query throws AssertionError
> "not a literal"
> ---------------------------------------------------------------------------------------------
>
> Key: CALCITE-5048
> URL: https://issues.apache.org/jira/browse/CALCITE-5048
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.29.0
> Reporter: Corvin Kuebler
> Assignee: Jiajun Xie
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This query:
> {code:java}
> // Does not run
> @Test void testDynamicParameterLimit() {
> CalciteAssert.hr()
> .query("SELECT * FROM \"hr\".\"emps\" AS a " +
> "WHERE \"deptno\" = " +
> "(SELECT MAX(\"deptno\") " +
> "FROM \"hr\".\"emps\" AS b " +
> "WHERE a.\"empid\" = b.\"empid\"" +
> ") LIMIT ?")
> .runs();
> }{code}
> results in the following exception:
> {code:java}
> not a literal: ?0
> java.lang.AssertionError: not a literal: ?0
> at org.apache.calcite.rex.RexLiteral.findValue(RexLiteral.java:1208)
> at org.apache.calcite.rex.RexLiteral.intValue(RexLiteral.java:1183)
> at
> org.apache.calcite.sql2rel.RelDecorrelator.decorrelateRel(RelDecorrelator.java:481)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:568)
> at org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:531)
> at
> org.apache.calcite.sql2rel.RelDecorrelator.getInvoke(RelDecorrelator.java:711)
> at
> org.apache.calcite.sql2rel.RelDecorrelator.decorrelate(RelDecorrelator.java:306)
> at
> org.apache.calcite.sql2rel.RelDecorrelator.decorrelateQuery(RelDecorrelator.java:230)
> at
> org.apache.calcite.tools.Programs$DecorrelateProgram.run(Programs.java:361)
> at
> org.apache.calcite.tools.Programs$SequenceProgram.run(Programs.java:336)
> at org.apache.calcite.prepare.Prepare.optimize(Prepare.java:177)
> at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:312)
> at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:220){code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
