[ 
https://issues.apache.org/jira/browse/CALCITE-5102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524660#comment-17524660
 ] 

Michael Mior commented on CALCITE-5102:
---------------------------------------

I'm on the fence as far as removing that from the repository, but I lean 
towards keeping it. The advantage of removing it is that we will use updated 
versions of many dependencies without the need for manual updates. However, 
things can still break in the event that a new dependency version has breaking 
changes we are somehow not prepared for. In that case, we have no idea what 
dependency changed that caused the issue and we have no way to go easily go 
back to something that worked unless someone somewhere has a working 
environment.

By keeping the lock file, we do risk problems with the Docker environment 
updating in a way that is incompatible with these dependencies. However, that 
could be fixed by being more strict about the Docker image we're using.

Finally, to be clear, removing the lock file would not have solved this 
particular issue since the dependency which is causing the problem was 
explicitly pinned to  version incompatible with the update to the Docker image.

> Avatica website fails to build
> ------------------------------
>
>                 Key: CALCITE-5102
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5102
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica
>            Reporter: Michael Mior
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The error below occurs when trying to build the repository via GitHub Actions.
> {noformat}
> Creating network "site_default" with the default driver
> Creating volume "site_gradle-cache" with default driver 
> Pulling build-site (jekyll/jekyll:4)... 
> 4: Pulling from jekyll/jekyll 
> Digest: sha256:5776c8eed572003d9ec021767d725b6aa37226bebf4a5219049c063ff8b698f
> Status: Downloaded newer image for jekyll/jekyll:4 
> Creating site_build-site_run ... 
> Creating site_build-site_run ... done 
> Cloning into '/tmp/calcite-avatica-go'... 
> Updated 0 paths from 74ec7ce 
> Bundler 2.3.11 is running, but your lockfile was generated with 2.3.10. 
> Installing Bundler 2.3.10 and restarting using that version. 
> Fetching gem metadata from [https://rubygems.org/.|https://rubygems.org/] 
> Fetching bundler 2.3.10 
> Installing bundler 2.3.10 
> Fetching gem metadata from [https://rubygems.org/.........] 
> Your bundle is locked to listen (3.1.5) from rubygems repository 
> [https://rubygems.org/] or installed locally, but that version can no longer 
> be 
> found in that source. That means the author of listen (3.1.5) has removed it. 
> You'll need to update your bundle to a version other than listen (3.1.5) that 
> hasn't been removed in order to install. 
> 7
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to