[
https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529292#comment-17529292
]
Alessandro Solimando edited comment on CALCITE-5118 at 4/28/22 8:16 AM:
------------------------------------------------------------------------
[~julianhyde], by "validating" you mean calling _SqlValidatorImpl_ or checking
the parameter numbers and throwing a validation error suffices?
I am asking because the current approach is the latter, while I am wondering if
we forgot to plug _SqlValidatorImpl_ in and we are doing some manual work that
should not be done.
was (Author: asolimando):
[~julianhyde], by "validating" you mean calling _SqlValidatorImpl_ or checking
the parameter types and throwing a validation error suffices?
I am asking because the current approach is the latter, while I am wondering if
we forgot to plug _SqlValidatorImpl_ in and we are doing some manual work that
should not be done.
> SqlDatePartFunction#rewriteCall should check operands length
> ------------------------------------------------------------
>
> Key: CALCITE-5118
> URL: https://issues.apache.org/jira/browse/CALCITE-5118
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.30.0
> Reporter: Benchao Li
> Assignee: Benchao Li
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.31.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {{SqlDatePartFunction#rewriteCall}} does not check operands length for now,
> and it will be rewrite to {{EXTRACT}} unconditionally before validation.
> E.g.
> {code:sql}
> select week(); -- will throw ArrayIndexOutOfBoundsException
> select week(date '2022-04-27', 1); -- will just ignore second param
> {code}
> However, these cases should throw validation exceptions, because {{week}}
> actually only accept 1 operand.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
