[ 
https://issues.apache.org/jira/browse/CALCITE-5143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533725#comment-17533725
 ] 

Mitsunori Komatsu edited comment on CALCITE-5143 at 5/9/22 9:47 AM:
--------------------------------------------------------------------

[~jiajunbernoulli] Wow, cool. Thanks.

But it seems Babel parser can't parse this SQL...

 
{code:java}
FrameworkConfig config = Frameworks.newConfigBuilder()
        .parserConfig(SqlParser.Config.DEFAULT
                .withParserFactory(SqlBabelParserImpl.FACTORY)
        )
        .build();
Planner planner = Frameworks.getPlanner(config);
System.out.println(planner.parse("SELECT DATEADD(S, 0, NOW())")); {code}
{code:java}
Exception in thread "main" org.apache.calcite.sql.parser.SqlParseException: 
Encountered "S" at line 1, column 16. Was expecting one of:
    "MILLISECOND" ...
    "SECOND" ...
    "MINUTE" ...
      :
    "CENTURY" ...
    "MILLENNIUM" ...
    
    at 
org.apache.calcite.sql.parser.babel.SqlBabelParserImpl.convertException(SqlBabelParserImpl.java:393)
    at 
org.apache.calcite.sql.parser.babel.SqlBabelParserImpl.normalizeException(SqlBabelParserImpl.java:157)
    at 
org.apache.calcite.sql.parser.SqlParser.handleException(SqlParser.java:145)
    at org.apache.calcite.sql.parser.SqlParser.parseQuery(SqlParser.java:160)
    at org.apache.calcite.sql.parser.SqlParser.parseStmt(SqlParser.java:185)
    at org.apache.calcite.prepare.PlannerImpl.parse(PlannerImpl.java:214){code}
 

 


was (Author: JIRAUSER288730):
[~jiajunbernoulli] Wow, cool. Thanks.

But it seems Babel parser can't parse this SQL...

 
{code:java}
FrameworkConfig config = Frameworks.newConfigBuilder()
        .parserConfig(SqlParser.Config.DEFAULT
                .withParserFactory(SqlBabelParserImpl.FACTORY)
        )
        .build();
Planner planner = Frameworks.getPlanner(config);
System.out.println(planner.parse("SELECT DATEADD(S, 0, NOW())")); {code}
{code:java}
Exception in thread "main" org.apache.calcite.sql.parser.SqlParseException: 
Encountered "S" at line 1, column 16. Was expecting one of:     "MILLISECOND" 
...
    "SECOND" ...
    "MINUTE" ...
{code}
 

 

> Planner#parse fails to parse a function when HOUR is passed as an argument
> --------------------------------------------------------------------------
>
>                 Key: CALCITE-5143
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5143
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.30.0
>            Reporter: Mitsunori Komatsu
>            Priority: Major
>
> I'm trying to parse and rewrite some SQL dialects including SQL Server which 
> supports some functions that receive HOUR as an argument using. But Calcite's 
> Planner#parse can't handle this kind of SQL.
> {code:java}
> FrameworkConfig config = Frameworks.newConfigBuilder().build();
> Planner planner = Frameworks.getPlanner(config);
> System.out.println(planner.parse("SELECT DATEDIFF(HOUR, NOW(), NOW())")); 
> {code}
> {code:java}
> Exception in thread "main" org.apache.calcite.sql.parser.SqlParseException: 
> Incorrect syntax near the keyword 'HOUR' at line 2, column 21.
> Was expecting one of:
>     "ALL" ...
>     "ARRAY" ...
>     "CASE" ...
>    :
>     "GROUPING" ...
>     "HOUR" ...
>     "HOUR" "(" ...
>     "*" ...
>     ")" ...
>     
>     at 
> org.apache.calcite.sql.parser.impl.SqlParserImpl.convertException(SqlParserImpl.java:389)
>     at 
> org.apache.calcite.sql.parser.impl.SqlParserImpl.normalizeException(SqlParserImpl.java:153)
>     at 
> org.apache.calcite.sql.parser.SqlParser.handleException(SqlParser.java:145)
>     at org.apache.calcite.sql.parser.SqlParser.parseQuery(SqlParser.java:160)
>     at org.apache.calcite.sql.parser.SqlParser.parseStmt(SqlParser.java:185)
>     at org.apache.calcite.prepare.PlannerImpl.parse(PlannerImpl.java:214)
>     at org.apache.calcite.tools.Planner.parse(Planner.java:50) {code}
> This issue happens with other date/time keyword-ish ones like YEAR.
> I guess it happens because HOUR and YEAR are reserved keywords.
> Is this an expected behavior? If so, is there any workaround?



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to