[
https://issues.apache.org/jira/browse/CALCITE-5118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17540308#comment-17540308
]
Julian Hyde commented on CALCITE-5118:
--------------------------------------
I generally can't tell whether a task is 'too big' unless I'm the one writing
the code. So I'll leave that to your judgment, [~libenchao]. For me, tasks
generally end up bigger than I expected, so and in these cases, I end up
splitting into two tasks (which might be two commits or two JIRA cases): one to
fix the bug without making the problem worse, and another a refactoring to get
rid of the problem.
> SqlDatePartFunction#rewriteCall should check operands length
> ------------------------------------------------------------
>
> Key: CALCITE-5118
> URL: https://issues.apache.org/jira/browse/CALCITE-5118
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.30.0
> Reporter: Benchao Li
> Assignee: Benchao Li
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.31.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {{SqlDatePartFunction#rewriteCall}} does not check operands length for now,
> and it will be rewrite to {{EXTRACT}} unconditionally before validation.
> E.g.
> {code:sql}
> select week(); -- will throw ArrayIndexOutOfBoundsException
> select week(date '2022-04-27', 1); -- will just ignore second param
> {code}
> However, these cases should throw validation exceptions, because {{week}}
> actually only accept 1 operand.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
