[
https://issues.apache.org/jira/browse/CALCITE-5167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Solimando updated CALCITE-5167:
------------------------------------------
Description:
As discussed in CALCITE-5118, {{SqlOperator#rewriteCall}} is done before
validation, which is hard to give accurate validation messages. We prefer to
use {{SqlRexConvertlet}} to do this work, hence we can make the validation
error more accurate, and does not give more burden to the optimization phase.
We should deprecate {{{}SqlOperator#rewriteCall{}}}, and move these rewriting
logic to {{SqlRexConvertlet.}}
Currently, {{{}SqlCoalesceFunction{}}}, {{{}SqlDatePartFunction{}}},
{{{}SqlJdbcFunctionCall{}}}, {{{}SqlNewOperator{}}}, {{{}SqlNullifFunction{}}},
{{SqlProcedureCallOperator}} used this mechanism, we should handle these
functions in this issue.
was:
As discussed in https://issues.apache.org/jira/browse/CALCITE-5118,
{{SqlOperator#rewriteCall}} is done before validation, which is hard to give
accurate validation messages. We prefer to use {{SqlRexConvertlet}} to do this
work, hence we can make the validation error more accurate, and does not give
more burden to the optimization phase.
We should deprecate {{{}SqlOperator#rewriteCall{}}}, and move these rewriting
logic to {{SqlRexConvertlet.}}
Currently, {{{}SqlCoalesceFunction{}}}, {{{}SqlDatePartFunction{}}},
{{{}SqlJdbcFunctionCall{}}}, {{{}SqlNewOperator{}}}, {{{}SqlNullifFunction{}}},
{{SqlProcedureCallOperator}} used this mechanism, we should handle these
functions in this issue.
> SqlOperator#rewriteCall does not give accurate validation error
> ---------------------------------------------------------------
>
> Key: CALCITE-5167
> URL: https://issues.apache.org/jira/browse/CALCITE-5167
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.30.0
> Reporter: Benchao Li
> Assignee: Benchao Li
> Priority: Major
> Fix For: 1.31.0
>
>
> As discussed in CALCITE-5118, {{SqlOperator#rewriteCall}} is done before
> validation, which is hard to give accurate validation messages. We prefer to
> use {{SqlRexConvertlet}} to do this work, hence we can make the validation
> error more accurate, and does not give more burden to the optimization phase.
> We should deprecate {{{}SqlOperator#rewriteCall{}}}, and move these rewriting
> logic to {{SqlRexConvertlet.}}
> Currently, {{{}SqlCoalesceFunction{}}}, {{{}SqlDatePartFunction{}}},
> {{{}SqlJdbcFunctionCall{}}}, {{{}SqlNewOperator{}}},
> {{{}SqlNullifFunction{}}}, {{SqlProcedureCallOperator}} used this mechanism,
> we should handle these functions in this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
