[ 
https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17551773#comment-17551773
 ] 

Julian Hyde commented on CALCITE-5169:
--------------------------------------

Can you describe in this case what the problem was, and what was your fix, and 
the relationship with other issues with simplifation/sargs/less-than.

Why did you add two RelOptRulesTest tests that are very similar to each other 
and not like the original case "x < 1 or x > 1"? Can you add comments to those 
tests about the desired result (because the next person probably won't navigate 
to the XML file). 

> 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'
> ----------------------------------------------------
>
>                 Key: CALCITE-5169
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5169
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.30.0
>            Reporter: Benchao Li
>            Assignee: Benchao Li
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.31.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> As described in the title, {{xx < 1 OR xx > 1}} should be simplified to {{xx 
> <> 1}}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to