[
https://issues.apache.org/jira/browse/CALCITE-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599297#comment-17599297
]
Bertil Chapuis commented on CALCITE-4294:
-----------------------------------------
Thank you for the feedback. I applied the cosmetic changes. Do not hesitate to
let me know if I missed something.
The 'round' method was named as 'roundGeom' in SQL. I now consistently use
'roundGeom' in java and SQL. Initially, I wanted to apply roundGeom to the
output of the tests instead of adding the function to SQL, however, I havn't
find an elegant way to limit the effect of this change to the spatial functions.
I think it was good to go through all the test cases again with a separate
commit. The first iterations had a couple of quick and dirty fixes and your
suggestion helped me spotting several issues.
> Use JTS rather than ESRI as the underlying library for geospatial (ST_)
> functions
> ---------------------------------------------------------------------------------
>
> Key: CALCITE-4294
> URL: https://issues.apache.org/jira/browse/CALCITE-4294
> Project: Calcite
> Issue Type: Bug
> Components: spatial
> Reporter: Julian Hyde
> Assignee: Bertil Chapuis
> Priority: Major
> Fix For: 1.32.0
>
>
> The geospatial functions are currently implemented using the ESRI library. We
> should consider using JTS instead. AT the time we started work on geospatial
> the JTS did not have a suitable license, but this is no longer the case. I
> gather that JTS is a superior library.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
