[
https://issues.apache.org/jira/browse/CALCITE-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mou Wu updated CALCITE-5265:
----------------------------
Description:
Add a case in RelToSqlConverterTest:
{code:java}
// code placeholder
@Test void testInsertValueWithDynamicParams() {
final String sql = "insert into \"DEPT\" values (?,?,?)";
final String expected = ""
+ "INSERT INTO \"SCOTT\".\"DEPT\" (\"DEPTNO\", \"DNAME\", \"LOC\")\n"
+ "SELECT ? AS \"DEPTNO\", ? AS \"DNAME\", ? AS \"LOC\"\n"
+ "FROM (VALUES (0)) AS \"t\" (\"ZERO\")";
sql(sql)
.schema(CalciteAssert.SchemaSpec.JDBC_SCOTT)
.ok(expected);
}{code}
will fail, because actual sql is with parentheses, maybe it's all right without
parentheses, but the behavior is different from Union operator, you can see
testInsertValuesWithDynamicParams in RelToSqlConverterTest class.
> Select operator' parentheses should be same with Union operator
> ---------------------------------------------------------------
>
> Key: CALCITE-5265
> URL: https://issues.apache.org/jira/browse/CALCITE-5265
> Project: Calcite
> Issue Type: Bug
> Reporter: Mou Wu
> Assignee: Mou Wu
> Priority: Trivial
>
> Add a case in RelToSqlConverterTest:
> {code:java}
> // code placeholder
> @Test void testInsertValueWithDynamicParams() {
> final String sql = "insert into \"DEPT\" values (?,?,?)";
> final String expected = ""
> + "INSERT INTO \"SCOTT\".\"DEPT\" (\"DEPTNO\", \"DNAME\", \"LOC\")\n"
> + "SELECT ? AS \"DEPTNO\", ? AS \"DNAME\", ? AS \"LOC\"\n"
> + "FROM (VALUES (0)) AS \"t\" (\"ZERO\")";
> sql(sql)
> .schema(CalciteAssert.SchemaSpec.JDBC_SCOTT)
> .ok(expected);
> }{code}
> will fail, because actual sql is with parentheses, maybe it's all right
> without parentheses, but the behavior is different from Union operator, you
> can see testInsertValuesWithDynamicParams in RelToSqlConverterTest class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
