[ 
https://issues.apache.org/jira/browse/CALCITE-5227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610381#comment-17610381
 ] 

Daniel Glöckner edited comment on CALCITE-5227 at 9/28/22 7:02 AM:
-------------------------------------------------------------------

[~julianhyde] I just fed the generated Java source code which results from my 
{{WideTableTest}} into javac and tried to use the generated method. It also 
crashes newer JVMs so I guess the test is a bit too extreme. I will see how the 
unit test in our business code behaves when I upgrade to Calcite with Janino >= 
3.1.8. 

I'll also check if there's a bug reported in OpenJDK that captures this issue 
(javac accepting the source file vs. JVM exploding at runtime).


was (Author: JIRAUSER288949):
[~julianhyde] I just fed the generated Java source code which results from my 
{{WideTableTest}} into javac and tried to use the generated method. It also 
crashes newer JVMs so I guess the test is a bit too extreme. I will see how the 
unit test in our business code behaves when I upgrade to Calcite with Janino >= 
3.1.8. I'll also check if there's a bug in OpenJDK that captures this issue 
(javac accepting the source file vs. JVM exploding at runtime).

> Janino upgrade breaks SELECTs with many projects causing JVM crashes
> --------------------------------------------------------------------
>
>                 Key: CALCITE-5227
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5227
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.30.0
>            Reporter: Daniel Glöckner
>            Priority: Critical
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In our case we have SELECTs with > 1000 project fields. You might say this is 
> a bit crazy but this is how our data model looks like ;)
> We recently upgraded to Calcite 1.30 and noticed JVM crashes for such 
> SELECTs. 
> After thorough analysis we found that the byte code produced by newer Janino 
> versions is 350 times larger compared to the byte code produced by javac. 
> I created a unit test to reproduce the issue in Calcite code base: 
> https://github.com/apache/calcite/commit/f4d4815dff5537c56b34b36794c71d7a9829eec6
> The Janino issue is tracked here: 
> https://github.com/janino-compiler/janino/issues/174



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to