[
https://issues.apache.org/jira/browse/CALCITE-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640219#comment-17640219
]
Ruben Q L commented on CALCITE-2989:
------------------------------------
[~freastro], could you please take a look at [~julianhyde]'s comments?
Apart from that, I can see that you have created two PRs: [one for
Calcite|https://github.com/apache/calcite/pull/2972], and [another one for
avatica|https://github.com/apache/calcite-avatica/pull/197]. If this change
needs to be applied on both, I think we'd need to create two Jira tickets: one
for Calcite (component "core", fix version: "1.33" or later?), and one for
Avatica (component "avatica", fix version "avatica-1.23"); and probably they
should be linked.
In terms of timing, could the patches be applied independently? Or do we need
to apply the PR first on avatica; and then on Calcite (once Calcite has
upgraded to the Avatica version containing the first patch)?
> The method ymdToJulian in DateTimeUtils returns wrong value
> -----------------------------------------------------------
>
> Key: CALCITE-2989
> URL: https://issues.apache.org/jira/browse/CALCITE-2989
> Project: Calcite
> Issue Type: Bug
> Components: avatica
> Reporter: vinoyang
> Assignee: Gregory Hart
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.33.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If we uses avatica's {{DateTimeUtils}} the dates less than 2299161 will cause
> an error result in Flink table/sql , test code :
> {code:java}
> testAllApis(
> "1500-04-30 12:00:00".cast(Types.SQL_TIMESTAMP),
> "'1500-04-30 12:00:00'.cast(SQL_TIMESTAMP)",
> "CAST('1500-04-30 12:00:00' AS TIMESTAMP)",
> "1500-04-30 12:00:00.0")
> {code}
> result :
> {code:java}
> Expected :1500-04-30 12:00:00.0
> Actual :1500-04-20 12:00:00.0
> {code}
> another case is here :
> https://issues.apache.org/jira/browse/FLINK-11935
> I find a key code snippet has been removed in CALCITE-1884 which caused this
> issue :
> {code:java}
> if (j < 2299161) {
> j = day + (153 * m + 2) / 5 + 365 * y + y / 4 - 32083;
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
