[
https://issues.apache.org/jira/browse/CALCITE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Starr updated CALCITE-5413:
---------------------------------
Description:
When SubQueryRemoveRule decorrelates a nested query, all correlated variables
are assumed to be bound to the scope of inner query.
{code:sql}
SELECT deptno
FROM emp e
WHERE EXISTS (
SELECT *
FROM dept d
WHERE EXISTS(
SELECT *
FROM emp_address ea
WHERE d.deptno = e.deptno
AND ea.empno = e.empno
{code}
Fails expand correctly, note the inner correlate with 2 correlate variables:
{code}
LogicalProject(DEPTNO=[$7])
LogicalCorrelate(correlation=[$cor0], joinType=[inner], requiredColumns=[{0,
7}])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
LogicalAggregate(group=[{0}])
LogicalProject(i=[true])
LogicalJoin(condition=[true], joinType=[inner], variablesSet=[[$cor0,
$cor1]])
LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
LogicalAggregate(group=[{0}])
LogicalProject(i=[true])
LogicalFilter(condition=[AND(=($0, $cor0.EMPNO), =($cor1.DEPTNO,
$cor0.DEPTNO))])
LogicalTableScan(table=[[CATALOG, SALES, EMP_ADDRESS]])
{code}
Creates the following error during decorrelation as well:
{code}
correlation id $cor1 not found in correlation list []
java.lang.AssertionError: correlation id $cor1 not found in correlation list []
at org.apache.calcite.util.Litmus.lambda$static$0(Litmus.java:31)
at
org.apache.calcite.rex.RexChecker.visitCorrelVariable(RexChecker.java:178)
at
org.apache.calcite.rex.RexChecker.visitCorrelVariable(RexChecker.java:61)
at
org.apache.calcite.rex.RexCorrelVariable.accept(RexCorrelVariable.java:49)
at
org.apache.calcite.rex.RexVisitorImpl.visitFieldAccess(RexVisitorImpl.java:98)
at
org.apache.calcite.rex.RexChecker.visitFieldAccess(RexChecker.java:153)
at
org.apache.calcite.rex.RexChecker.visitFieldAccess(RexChecker.java:61)
at org.apache.calcite.rex.RexFieldAccess.accept(RexFieldAccess.java:94)
at org.apache.calcite.rel.core.Project.isValid(Project.java:245)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:53)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.BiRel.childrenAccept(BiRel.java:46)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.BiRel.childrenAccept(BiRel.java:46)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.RelVisitor.go(RelVisitor.java:63)
at org.apache.calcite.test.Matchers$4.matchesSafely(Matchers.java:214)
{code}
was:
When SubQueryRemoveRule decorrelates a nested query, all correlated variables
are assumed to be bound to the scope of inner query.
{code:sql}
SELECT deptno
FROM emp e
WHERE EXISTS (
SELECT *
FROM dept d
WHERE EXISTS(
SELECT *
FROM emp_address ea
WHERE d.deptno = e.deptno
AND ea.empno = e.empno
{code}
Fails expand correctly, note the inner correlate with 2 correlate variables:
{code}
LogicalProject(DEPTNO=[$7])
LogicalCorrelate(correlation=[$cor0], joinType=[inner], requiredColumns=[{0,
7}])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
LogicalAggregate(group=[{0}])
LogicalProject(i=[true])
LogicalJoin(condition=[true], joinType=[inner], variablesSet=[[$cor0,
$cor1]])
LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
LogicalAggregate(group=[{0}])
LogicalProject(i=[true])
LogicalFilter(condition=[AND(=($0, $cor0.EMPNO), =($cor1.DEPTNO,
$cor0.DEPTNO))])
LogicalTableScan(table=[[CATALOG, SALES, EMP_ADDRESS]])
{code}
Creates the following error:
{code}
correlation id $cor1 not found in correlation list []
java.lang.AssertionError: correlation id $cor1 not found in correlation list []
at org.apache.calcite.util.Litmus.lambda$static$0(Litmus.java:31)
at
org.apache.calcite.rex.RexChecker.visitCorrelVariable(RexChecker.java:178)
at
org.apache.calcite.rex.RexChecker.visitCorrelVariable(RexChecker.java:61)
at
org.apache.calcite.rex.RexCorrelVariable.accept(RexCorrelVariable.java:49)
at
org.apache.calcite.rex.RexVisitorImpl.visitFieldAccess(RexVisitorImpl.java:98)
at
org.apache.calcite.rex.RexChecker.visitFieldAccess(RexChecker.java:153)
at
org.apache.calcite.rex.RexChecker.visitFieldAccess(RexChecker.java:61)
at org.apache.calcite.rex.RexFieldAccess.accept(RexFieldAccess.java:94)
at org.apache.calcite.rel.core.Project.isValid(Project.java:245)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:53)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.BiRel.childrenAccept(BiRel.java:46)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.BiRel.childrenAccept(BiRel.java:46)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
at
org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
at org.apache.calcite.rel.RelVisitor.go(RelVisitor.java:63)
at org.apache.calcite.test.Matchers$4.matchesSafely(Matchers.java:214)
at org.apache.calcite.test.Matchers$4.matchesSafely(Matchers.java:207)
at org.hamcrest.TypeSafeMatcher.matches(TypeSafeMatcher.java:67)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:10)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
at
org.apache.calcite.test.RelOptFixture.checkPlanning(RelOptFixture.java:402)
at org.apache.calcite.test.RelOptFixture.check(RelOptFixture.java:330)
at org.apache.calcite.test.RelOptFixture.check(RelOptFixture.java:314)
at
org.apache.calcite.test.RelOptRulesTest.testNestedCorrelatedQueriesUsingOuterContext(RelOptRulesTest.java:4488)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
at
org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at
org.junit.jupiter.engine.extension.SameThreadTimeoutInvocation.proceed(SameThreadTimeoutInvocation.java:45)
at
org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:156)
at
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:147)
at
org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:86)
at
org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:103)
at
org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at
org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at
org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)
at
org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:86)
at
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:217)
at
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:213)
at
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:138)
at
org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:68)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
at
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at
org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
at
org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at
org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
at
org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at
org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at
org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at
org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at
org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
at java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:189)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
at
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
at
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)
{code}
> Nested Subqueries with correlated variables are not decorrelated correctly
> ----------------------------------------------------------------------------
>
> Key: CALCITE-5413
> URL: https://issues.apache.org/jira/browse/CALCITE-5413
> Project: Calcite
> Issue Type: Improvement
> Reporter: James Starr
> Assignee: James Starr
> Priority: Major
>
> When SubQueryRemoveRule decorrelates a nested query, all correlated variables
> are assumed to be bound to the scope of inner query.
> {code:sql}
> SELECT deptno
> FROM emp e
> WHERE EXISTS (
> SELECT *
> FROM dept d
> WHERE EXISTS(
> SELECT *
> FROM emp_address ea
> WHERE d.deptno = e.deptno
> AND ea.empno = e.empno
> {code}
> Fails expand correctly, note the inner correlate with 2 correlate variables:
> {code}
> LogicalProject(DEPTNO=[$7])
> LogicalCorrelate(correlation=[$cor0], joinType=[inner],
> requiredColumns=[{0, 7}])
> LogicalTableScan(table=[[CATALOG, SALES, EMP]])
> LogicalAggregate(group=[{0}])
> LogicalProject(i=[true])
> LogicalJoin(condition=[true], joinType=[inner], variablesSet=[[$cor0,
> $cor1]])
> LogicalTableScan(table=[[CATALOG, SALES, DEPT]])
> LogicalAggregate(group=[{0}])
> LogicalProject(i=[true])
> LogicalFilter(condition=[AND(=($0, $cor0.EMPNO),
> =($cor1.DEPTNO, $cor0.DEPTNO))])
> LogicalTableScan(table=[[CATALOG, SALES, EMP_ADDRESS]])
> {code}
> Creates the following error during decorrelation as well:
> {code}
>
> correlation id $cor1 not found in correlation list []
> java.lang.AssertionError: correlation id $cor1 not found in correlation list
> []
> at org.apache.calcite.util.Litmus.lambda$static$0(Litmus.java:31)
> at
> org.apache.calcite.rex.RexChecker.visitCorrelVariable(RexChecker.java:178)
> at
> org.apache.calcite.rex.RexChecker.visitCorrelVariable(RexChecker.java:61)
> at
> org.apache.calcite.rex.RexCorrelVariable.accept(RexCorrelVariable.java:49)
> at
> org.apache.calcite.rex.RexVisitorImpl.visitFieldAccess(RexVisitorImpl.java:98)
> at
> org.apache.calcite.rex.RexChecker.visitFieldAccess(RexChecker.java:153)
> at
> org.apache.calcite.rex.RexChecker.visitFieldAccess(RexChecker.java:61)
> at org.apache.calcite.rex.RexFieldAccess.accept(RexFieldAccess.java:94)
> at org.apache.calcite.rel.core.Project.isValid(Project.java:245)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:53)
> at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.BiRel.childrenAccept(BiRel.java:46)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.BiRel.childrenAccept(BiRel.java:46)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.SingleRel.childrenAccept(SingleRel.java:72)
> at org.apache.calcite.rel.RelVisitor.visit(RelVisitor.java:46)
> at
> org.apache.calcite.rel.RelValidityChecker.visit(RelValidityChecker.java:56)
> at org.apache.calcite.rel.RelVisitor.go(RelVisitor.java:63)
> at org.apache.calcite.test.Matchers$4.matchesSafely(Matchers.java:214)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
