[ 
https://issues.apache.org/jira/browse/CALCITE-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676975#comment-17676975
 ] 

Julian Hyde commented on CALCITE-5450:
--------------------------------------

I've made some progress in my 5450-week branch.

Remaining work:
 * Tanner added support for WEEK, WEEKS, QUARTER, QUARTERS but I don't see any 
tests for plurals. We need some
 * reference.md states "Interval literals may only use time units YEAR, MONTH, 
DAY, HOUR, MINUTE and SECOND". This comment needs to be updated.
 * Tests for ISOYEAR in DATE_TRUNC and FLOOR functions (in big-query.iq and 
SqlOperatorTests) seem to give the wrong answer. Probably ISOYEAR never worked. 
It needs to work.

[~tanclary], [~oliverlee], Can one of you do the remaining work, starting from 
my 5450-week branch?

> Add support for WEEK(WEEKDAY) for custom time frames to relevant functions
> --------------------------------------------------------------------------
>
>                 Key: CALCITE-5450
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5450
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Oliver Lee
>            Assignee: Oliver Lee
>            Priority: Minor
>
> Some BIG_QUERY functions (i.e. {{{}EXTRACT(){}}}, {{DATE_TRUNC()}} ) can 
> accept the operand
> {{WEEK(WEEKDAY)}} where {{WEEKDAY}} is one of {{SUNDAY, MONDAY, TUESDAY, 
> WEDNESDAY, THURSDAY, FRIDAY, SATURDAY}}
>  
> This is not currently supported.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to