[ 
https://issues.apache.org/jira/browse/CALCITE-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17680434#comment-17680434
 ] 

Julian Hyde edited comment on CALCITE-5450 at 1/25/23 7:41 AM:
---------------------------------------------------------------

Fixed in 
[7fb85780|https://github.com/apache/calcite/commit/7fb8578059b964981d333072895e51fcab3f5893];
 thanks for the fix, [~oliverlee] and [~tanclary]!


was (Author: julianhyde):
Fixed in 
[13ef58|https://github.com/apache/calcite/commit/13ef58b50655ce63d88f60c736c5fae4701a8300];
 thanks for the fix, [~oliverlee] and [~tanclary]!

> Add support for WEEK(WEEKDAY) for custom time frames to relevant functions
> --------------------------------------------------------------------------
>
>                 Key: CALCITE-5450
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5450
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Oliver Lee
>            Assignee: Oliver Lee
>            Priority: Minor
>             Fix For: 1.33.0
>
>
> Some BigQuery functions, such as {{EXTRACT}} and {{{}DATE_TRUNC{}}}, accept 
> the operand {{{}WEEK(weekday){}}}, where {{weekday}} is one of {{{}SUNDAY, 
> MONDAY, TUESDAY, WEDNESDAY, THURSDAY, FRIDAY, SATURDAY{}}}. After this 
> change, any function that accepts {{WEEK}} or {{ISOWEEK}} timeframe will also 
> accept {{WEEK(SUNDAY)}} etc.
>  
> Note that {{WEEK}} is equivalent to {{WEEK(SUNDAY)}} and {{ISOWEEK}} is 
> equivalent to {{{}WEEK(MONDAY){}}}.
> In this change we also allow {{WEEKS}} as a synonym for {{{}WEEK{}}}, and 
> {{QUARTERS}} as a synonym for {{{}QUARTER{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to