[
https://issues.apache.org/jira/browse/CALCITE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687503#comment-17687503
]
Julian Hyde commented on CALCITE-5501:
--------------------------------------
[~zabetak], I think with {{DiffRepository}} I implemented approval tests years
before they became popular (or there was even a name for them). I think that
{{DiffRepository}}-based tests work well for Calcite and I think we should
stick with it.
> SqlToRelConverterTest.checkActualAndReferenceFiles fails intermittently in
> Jenkins CI
> -------------------------------------------------------------------------------------
>
> Key: CALCITE-5501
> URL: https://issues.apache.org/jira/browse/CALCITE-5501
> Project: Calcite
> Issue Type: Bug
> Components: tests
> Affects Versions: 1.32.0
> Reporter: Stamatis Zampetakis
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.34.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Sample runs that failed due to
> SqlToRelConverterTest.checkActualAndReferenceFiles:
> *
> https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/main/15/console
> *
> https://ci-builds.apache.org/job/Calcite/job/Calcite-sonar/job/main/18/console
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
