[
https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690674#comment-17690674
]
Julian Hyde commented on CALCITE-5477:
--------------------------------------
I think I prefer your second option, "Make release builds of Calcite using an
older version of Guava (prior to 20.0)". We would change the Guava version in
gradle.properties to 19.0.
Can we time-box this to, say, six months. Every Calcite release after August
2023 will be built using the latest Guava, and the minimum supported Guava
would be 20.0.
During that six months Druid needs to upgrade to Guava 20.0 or higher. (Yes, I
know that you have dependencies that are hard to arm-twist.) Or start doing a
private build of Calcite.
> Prefer Util.checkArgument over Preconditions.checkArgument
> ----------------------------------------------------------
>
> Key: CALCITE-5477
> URL: https://issues.apache.org/jira/browse/CALCITE-5477
> Project: Calcite
> Issue Type: Improvement
> Reporter: Gian Merlino
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Related to CALCITE-5428.
> Preconditions.checkArgument gained new overloads in Guava 20.0, which
> prevents code built using Guava 20.0 from running properly with earlier
> versions of Guava. (When building against a later version of Guava, as
> Calcite does by default, the Java compiler generates calls to methods that
> don't exist in those earlier versions.)
> Example: in Guava 20.0 there is {{checkArgument(boolean, String, int)}}; in
> earlier versions this would be handled by {{checkArgument(boolean, String,
> Object...)}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
